Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20680 )
Change subject: KUDU-3523 Use f_bsize as Kudu block size instead of st_blksize ...................................................................... Patch Set 4: > Patch Set 4: > > The reason behind 64K block size on XFS could be because the filesystem was > created with "-b size=64K" mkfs option. Could you confirm that? > > Also, in such cases, even though user is able to create a filesystem with > block size greater than general page size on linux i.e. 4K, default mount API > may not work because kernel is compiled with 4K default page size and it > doesn't allow a filesystem with more than 4K block size to be mounted. > This could be one of the possibilities. > > Could you please share the following information: > 1. Output of command -> "getconf PAGE_SIZE" on the node where xfs filesystem > is hosted > 2. mkfs command used to create xfs filesystem (i.e. /dev/vdb) > 3. Check if punch hole is supported on a filesystem with block size more than > 4K. 1. The output of command "getconf PAGE_SIZE" is 65536. 2. It is a docker image, I do not know the mkfs command. 3. XFS supports punch hole, see src/kudu/util/env_posix.cc#PunchHole(). And unit test case TestEnv.TestHolePunch runs successfully on my XFS file sytem. More detail see the issue. Thanks. -- To view, visit http://gerrit.cloudera.org:8080/20680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04343caf5fe377a4fa9b57e6e450307e6b995928 Gerrit-Change-Number: 20680 Gerrit-PatchSet: 4 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Tue, 12 Dec 2023 03:47:30 +0000 Gerrit-HasComments: No
