Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 )
Change subject: KUDU-3527 Fix block manager test on 64k filesystems ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/20725/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20725/7//COMMIT_MSG@10 PS7, Line 10: fs_block_size What's "fs_block_size"? Is it indeed the filesystem's block size (i.e. what 'stat -f' reports) or this is about the IO block size (a.k.a. optimal block size for I/O, or what 'stat' reports)? It would great to have more clarity here in the commit message at least since there is a lot of confusion around this topic already, and bringing in some more isn't a good idea, not at all. Same for the comments in the code, etc. On my Graviton3 VM, the actual FS block size for an XFS filesystem is 4K, but the optimal IO block size is 64K: [root@aserbin-rh88-graviton3 ~]# stat -f .bashrc File: ".bashrc" ID: 1030300000000 Namelen: 255 Type: xfs Block size: 4096 Fundamental block size: 4096 Blocks: Total: 52243707 Free: 9130378 Available: 9130378 Inodes: Total: 73555248 Free: 73076679 [root@aserbin-rh88-graviton3 ~]# stat .bashrc File: .bashrc Size: 307 Blocks: 8 IO Block: 65536 regular file Device: 10303h/66307d Inode: 1223994 Links: 1 Access: (0644/-rw-r--r--) Uid: ( 0/ root) Gid: ( 0/ root) Access: 2024-01-19 11:03:05.043364091 -0800 Modify: 2023-10-06 16:47:49.797395518 -0700 Change: 2023-10-06 16:47:49.797395518 -0700 Birth: 2023-10-06 16:47:49.797395518 -0700 -- To view, visit http://gerrit.cloudera.org:8080/20725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e325bde502b7d7f39dd17fa84cb7eb42a3d7c20 Gerrit-Change-Number: 20725 Gerrit-PatchSet: 7 Gerrit-Owner: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Comment-Date: Fri, 19 Jan 2024 19:17:58 +0000 Gerrit-HasComments: Yes
