Alexey Serbin has uploaded this change for review. (
http://gerrit.cloudera.org:8080/20961
Change subject: [rpc] validate security-related parameters earlier
......................................................................
[rpc] validate security-related parameters earlier
This patch moves the verification of a few security-related RPC flags
from the connection negotiation time (i.e. DoServerNegotiation()) into
the server bootstrap time (i.e. RpcServer::Init()).
This is more optimal because:
* misconfiguration are spot earlier: if this type of misconfiguration
is detected, the outcome is visible and actionable outright since
the server simply refuses to start, reporting on the issue
* there isn't a way to have a Kudu server running with such an issue
* some amount of CPU resources is spared since a server no longer
performs the same verification over and over again when establishing
a new RPC connection, but performs it once during the start-up time
Change-Id: Ie16537c440041c9ee74276da35f2599592ef7e04
---
M src/kudu/rpc/negotiation.cc
M src/kudu/server/rpc_server.cc
2 files changed, 14 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/20961/1
--
To view, visit http://gerrit.cloudera.org:8080/20961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie16537c440041c9ee74276da35f2599592ef7e04
Gerrit-Change-Number: 20961
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <ale...@apache.org>
