Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20961 )
Change subject: [rpc] validate security-related parameters earlier ...................................................................... Patch Set 1: (1 comment) > Would it makes sense to add a basic test, to verify that the > verification works as intended? It's a good idea! Done. http://gerrit.cloudera.org:8080/#/c/20961/1/src/kudu/server/rpc_server.cc File src/kudu/server/rpc_server.cc: http://gerrit.cloudera.org:8080/#/c/20961/1/src/kudu/server/rpc_server.cc@166 PS1, Line 166: return Status::InvalidArgument( > +1 Good point! Done. -- To view, visit http://gerrit.cloudera.org:8080/20961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie16537c440041c9ee74276da35f2599592ef7e04 Gerrit-Change-Number: 20961 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Sat, 24 Feb 2024 05:00:03 +0000 Gerrit-HasComments: Yes
