Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21004 )
Change subject: [catalog_manager] Tighten leader UUID fallback ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21004/1//COMMIT_MSG Commit Message: PS1: Thank you for getting to the bottom of this! Do you think it makes sense to add a new test or update the existing one (TestRecreateCMeta?) to make the issue happening more consistently when the fix is not present? My concern is that KUDU-2335 was manifesting itself rarely, and if there is a regression in the code once it's updated, it would be hard to detect the issue right away. http://gerrit.cloudera.org:8080/#/c/21004/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/21004/1/src/kudu/master/catalog_manager.cc@5456 PS1, Line 5456: // previous cstate, and the leader was known for that term. Could you please add an extra comment, explaining the essence of the extra criterion added? The extra comment might be something like below (but it's up to you to decide what's the best way to describe the rationale, of course): An extra condition is to check whether it's a report from a former leader replica which currently doesn't maintain the leadership role. Such a situation is possible when the replica's cmeta file had been deleted and then recreated (e.g. by the "kudu local_replica cmeta unsafe_recreate" CLI tool). The code below assumes that the replica effectively has the leadership if the 'leader_uuid' field is set, but that's not so (see KUDU-2335). -- To view, visit http://gerrit.cloudera.org:8080/21004 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06a80a4a0a9fd422b50860e8cd8bf0e12973cd43 Gerrit-Change-Number: 21004 Gerrit-PatchSet: 1 Gerrit-Owner: Ádám Bakai <aba...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 07 Feb 2024 01:11:35 +0000 Gerrit-HasComments: Yes
