Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21004 )
Change subject: [catalog_manager] Tighten leader UUID fallback ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21004/1//COMMIT_MSG Commit Message: PS1: > I added an extension to the TestRecreateCMeta so that it is tested in singl The reason for KUDU-2335 is still a mystery to me. Maybe, that's indeed some race, but at least your fix helps to address one of the cases when the DCHECK() in quorum_util.cc on non-healthy leader triggered. Thanks! http://gerrit.cloudera.org:8080/#/c/21004/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/21004/1/src/kudu/master/catalog_manager.cc@5456 PS1, Line 5456: // previous cstate, and the leader was known for that term. > Done This comment says 'Done', but I could not see the requested extra comment in PS2. Did I miss something? -- To view, visit http://gerrit.cloudera.org:8080/21004 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I06a80a4a0a9fd422b50860e8cd8bf0e12973cd43 Gerrit-Change-Number: 21004 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai <aba...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Ádám Bakai <aba...@cloudera.com> Gerrit-Comment-Date: Thu, 08 Feb 2024 06:18:19 +0000 Gerrit-HasComments: Yes
