Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 )
Change subject: KUDU-613: Introduce SLRU cache ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/20607/10/src/kudu/util/slru_cache.h File src/kudu/util/slru_cache.h: http://gerrit.cloudera.org:8080/#/c/20607/10/src/kudu/util/slru_cache.h@136 PS10, Line 136: // Returns the lookup handle of entry from probationary segment, same entry is moved to It would be great to document the parameters of this NewSLRUCache() function, in particular, it's not exactly clear what 'lookups' might be necessary for if somebody is looking at this function the very first time. http://gerrit.cloudera.org:8080/#/c/20607/8/src/kudu/util/slru_cache.h File src/kudu/util/slru_cache.h: http://gerrit.cloudera.org:8080/#/c/20607/8/src/kudu/util/slru_cache.h@50 PS8, Line 50: class HandleDeleter { : public: : explicit HandleDeleter(SLRUCache* c) : : c_(c) { : } : : void operator()(Handle* h) const { : if (h != nullptr) { : c_->Release(h); : } : } : : SLRUCache* cache() const { : return c_; : } : : private: : SLRUCache* c_; : }; > I did so, but for any uses of this templatized class both Free() and Releas I guess that's OK. -- To view, visit http://gerrit.cloudera.org:8080/20607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45531534a2049dd38c002f4dc7982df9fd46e0bb Gerrit-Change-Number: 20607 Gerrit-PatchSet: 8 Gerrit-Owner: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 08 Feb 2024 05:57:37 +0000 Gerrit-HasComments: Yes
