Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 )
Change subject: KUDU-613: Introduce SLRU cache ...................................................................... Patch Set 12: (4 comments) Fixed the ASAN test error and addressed the comments left by tidy bot. http://gerrit.cloudera.org:8080/#/c/20607/11/src/kudu/util/slru_cache-test.cc File src/kudu/util/slru_cache-test.cc: http://gerrit.cloudera.org:8080/#/c/20607/11/src/kudu/util/slru_cache-test.cc@310 PS11, Line 310: const int size_per_elem = static_cast<int>(total_cache_size_ / kNumElems); > warning: narrowing conversion from 'unsigned long' to signed type 'int' is Done http://gerrit.cloudera.org:8080/#/c/20607/11/src/kudu/util/slru_cache-test.cc@333 PS11, Line 333: const int weight = static_cast<int>(protected_segment_size_ / 100); > warning: narrowing conversion from 'unsigned long' to signed type 'int' is Done http://gerrit.cloudera.org:8080/#/c/20607/11/src/kudu/util/slru_cache-test.cc@396 PS11, Line 396: Insert(entry, delta * 2 + entry, static_cast<int>(1.25 * weight)); > warning: narrowing conversion from 'double' to 'int' [bugprone-narrowing-co Done http://gerrit.cloudera.org:8080/#/c/20607/11/src/kudu/util/slru_cache-test.cc@409 PS11, Line 409: const int weight = static_cast<int>(protected_segment_size_ / 100); > warning: narrowing conversion from 'unsigned long' to signed type 'int' is Done -- To view, visit http://gerrit.cloudera.org:8080/20607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45531534a2049dd38c002f4dc7982df9fd46e0bb Gerrit-Change-Number: 20607 Gerrit-PatchSet: 12 Gerrit-Owner: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 13 Feb 2024 21:39:50 +0000 Gerrit-HasComments: Yes
