Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21098 )
Change subject: [compaction] Code cleanup and readability improvement ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21098/3/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: http://gerrit.cloudera.org:8080/#/c/21098/3/src/kudu/tablet/compaction.cc@993 PS3, Line 993: const CompactionInputRow old_row Should this be passed as const reference instead? const CompactionInputRow& old_row -- To view, visit http://gerrit.cloudera.org:8080/21098 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I54709b5e27751581c889854911323fbddab1c4ab Gerrit-Change-Number: 21098 Gerrit-PatchSet: 3 Gerrit-Owner: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Comment-Date: Wed, 03 Apr 2024 17:38:54 +0000 Gerrit-HasComments: Yes
