KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time ...................................................................... Patch Set 3: (7 comments) Thanks for your reviews. http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/ops/alter_schema_op.cc File src/kudu/tablet/ops/alter_schema_op.cc: http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/ops/alter_schema_op.cc@179 PS2, Line 179: DCHECK_EQ(result, Op::APPLIED); > 1. Should this metric also statistics the duraction when the ops aborted (l 1.done 2.The scope of ScopedLatencyMetric is limited and not quite suitable here; I will use a lambda function to achieve a similar functionality. http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_metrics.cc File src/kudu/tablet/tablet_metrics.cc: http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_metrics.cc@227 PS2, Line 227: METRIC_DEFINE_histogram(tablet, alter_schema_duration, > nit: Leave one blank line is enough. Done http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc File src/kudu/tablet/tablet_replica-test.cc: http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc@267 PS2, Line 267: const int orig_schema_version = tablet()->metadata()->schema_version(); > Is 'orig_schema_pb' necessary? Removed. http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc@272 PS2, Line 272: const auto before_cnt = alter_schema_duration->TotalCount(); : > Is it possible to get the metric via tablet_replica_->tablet()->metrics()-> Done http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc@274 PS2, Line 274: // Add a new column. > nit: add 'const' Done http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc@279 PS2, Line 279: ASSERT_OK(UpdateSchema(new_schema, orig_schema_version + 1)); > Is 'new_client_schema' necessary? Removed. http://gerrit.cloudera.org:8080/#/c/21300/2/src/kudu/tablet/tablet_replica-test.cc@285 PS2, Line 285: TEST_F(TabletReplicaTest, TestMRSAnchorPreventsLogGC) { : ConsensusBootstrapInfo info; > Is this debugging purpose only? Remove it if not necessary, check the metri Done -- To view, visit http://gerrit.cloudera.org:8080/21300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a Gerrit-Change-Number: 21300 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Thu, 18 Apr 2024 06:24:51 +0000 Gerrit-HasComments: Yes
