Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21300 )
Change subject: [metrics] Add tablet level metrics for alter schema op time ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21300/4/src/kudu/tablet/ops/alter_schema_op.cc File src/kudu/tablet/ops/alter_schema_op.cc: http://gerrit.cloudera.org:8080/#/c/21300/4/src/kudu/tablet/ops/alter_schema_op.cc@158 PS4, Line 158: auto update_metrics = [this]() { How about making it as a ScopedCleanup, then you don't need to call it manually in every return. -- To view, visit http://gerrit.cloudera.org:8080/21300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I034fc3141349a940ee8aaac22ca90e1948fc7a6a Gerrit-Change-Number: 21300 Gerrit-PatchSet: 4 Gerrit-Owner: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Sat, 11 May 2024 03:10:59 +0000 Gerrit-HasComments: Yes
