Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 )
Change subject: KUDU-3371 Fix the crash bug when run binaries on older CPU machines ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/21287/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21287/1//COMMIT_MSG@7 PS1, Line 7: KUDU-3371 > Use a dedicated jira ID that addresses this specific crash. KUDU-3371 is a +1 http://gerrit.cloudera.org:8080/#/c/21287/1//COMMIT_MSG@11 PS1, Line 11: the nit: drop http://gerrit.cloudera.org:8080/#/c/21287/1//COMMIT_MSG@12 PS1, Line 12: the nit: a http://gerrit.cloudera.org:8080/#/c/21287/1//COMMIT_MSG@12 PS1, Line 12: (e.g. AVX512) Are you sure that was the only reason behind those crashes? As already pointed at other reviewers, it might help to summarize your findings in an upstream JIRA item. Let me know if you want me to help with providing information on crashes I see in my environment. Thank you! http://gerrit.cloudera.org:8080/#/c/21287/1//COMMIT_MSG@15 PS1, Line 15: WITH_SNAPPY > nit: Should this be 'PORTABLE'? +1 http://gerrit.cloudera.org:8080/#/c/21287/1//COMMIT_MSG@15 PS1, Line 15: build nit: building http://gerrit.cloudera.org:8080/#/c/21287/1//COMMIT_MSG@15 PS1, Line 15: enable nit: enables -- To view, visit http://gerrit.cloudera.org:8080/21287 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id30ae995c41a592fccbdb822bc1f457c5e6878ac Gerrit-Change-Number: 21287 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Thu, 02 May 2024 19:42:37 +0000 Gerrit-HasComments: Yes
