Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21287 )

Change subject: KUDU-3580 the crash bug when run binaries on older CPU machines
......................................................................


Patch Set 2:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/21287/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21287/1//COMMIT_MSG@7
PS1, Line 7: KUDU-3580
> +1
Done, KUDU-3580 is created.


http://gerrit.cloudera.org:8080/#/c/21287/1//COMMIT_MSG@11
PS1, Line 11: mac
> nit: drop
Done


http://gerrit.cloudera.org:8080/#/c/21287/1//COMMIT_MSG@12
PS1, Line 12: (e.g. AVX512)
> Are you sure that was the only reason behind those crashes?
I'm not sure if there are any other reasons.

It's a appreciate if you would take some time to check it, thanks!


http://gerrit.cloudera.org:8080/#/c/21287/1//COMMIT_MSG@12
PS1, Line 12: a
> nit: a
Done


http://gerrit.cloudera.org:8080/#/c/21287/1//COMMIT_MSG@15
PS1, Line 15: enable
> nit: enables
Done


http://gerrit.cloudera.org:8080/#/c/21287/1//COMMIT_MSG@15
PS1, Line 15:  PORTABLE o
> +1
Oh, yes, it's a mistake.


http://gerrit.cloudera.org:8080/#/c/21287/1//COMMIT_MSG@15
PS1, Line 15: ildin
> nit: building
Done



--
To view, visit http://gerrit.cloudera.org:8080/21287
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id30ae995c41a592fccbdb822bc1f457c5e6878ac
Gerrit-Change-Number: 21287
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <laiyingc...@apache.org>
Gerrit-Reviewer: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: KeDeng <kdeng...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com>
Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org>
Gerrit-Comment-Date: Sun, 26 May 2024 15:21:55 +0000
Gerrit-HasComments: Yes

Reply via email to