Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21389 )
Change subject: KUDU-613: Introduce new BlockCache metrics ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21389/2/src/kudu/util/block_cache_metrics.cc File src/kudu/util/block_cache_metrics.cc: PS2: > Do we need to also have metrics for entries moving between segments? The new metrics give us information on inserts into the protected segment of the block cache (block_cache_protected_segment_inserts). That lets us know how many entries were upgraded from the probationary segment to the protected segment. They also give us information on evictions from the protected segment of the block cache (block_cache_protected_segment_evictions). This lets us know how many entries were downgraded from the protected segment to the probationary segment. Are there specific metrics that are currently missing that you had in mind? -- To view, visit http://gerrit.cloudera.org:8080/21389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c8181ec6bea301605aaef7db0003c3eaef3072d Gerrit-Change-Number: 21389 Gerrit-PatchSet: 3 Gerrit-Owner: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Comment-Date: Fri, 10 May 2024 16:54:53 +0000 Gerrit-HasComments: Yes
