Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21389 )
Change subject: KUDU-613: Introduce new BlockCache metrics ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21389/2/src/kudu/util/block_cache_metrics.cc File src/kudu/util/block_cache_metrics.cc: PS2: > From the usability perspective, I'd think of all the metrics that allow for I was thinking more in the terms of a single entry life journey tracking i.e. how many times a single entry has been inserted and evicted from protected segments. It might help addressing issues where protected segment is not sized appropriately for the query pattern. But if that can be worked as an enhancement as it might be complicated to track a single entry, probably we can scope it out of this change list. -- To view, visit http://gerrit.cloudera.org:8080/21389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c8181ec6bea301605aaef7db0003c3eaef3072d Gerrit-Change-Number: 21389 Gerrit-PatchSet: 4 Gerrit-Owner: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Comment-Date: Thu, 16 May 2024 23:02:15 +0000 Gerrit-HasComments: Yes
