Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/21447 )
Change subject: Add a benchmark for CBTree concurrent writes. ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/21447/4/src/kudu/tablet/cbtree-test.cc File src/kudu/tablet/cbtree-test.cc: http://gerrit.cloudera.org:8080/#/c/21447/4/src/kudu/tablet/cbtree-test.cc@57 PS4, Line 57: N > No specific reason, I just had 8 core. So I put it to +1. Also I wanted dif You could use the same logic to output of hardware_concurrency() as you did for 8 cores. However, it is fine if you don't see much benefit in using hardware_concurrency(). http://gerrit.cloudera.org:8080/#/c/21447/8/src/kudu/tablet/cbtree-test.cc File src/kudu/tablet/cbtree-test.cc: http://gerrit.cloudera.org:8080/#/c/21447/8/src/kudu/tablet/cbtree-test.cc@924 PS8, Line 924: ConcurrentReadWriteBenchmark Don't want to delay your commit. Would it make sense to include this as part of benchmark suite? I noticed the TestScanPerformance is already part of the suite(https://github.com/apache/kudu/blob/8d5f82483665fd6229d08fdfe94c87b07f80f986/src/kudu/scripts/benchmarks.sh#L246-L251). Maybe we can add this test as well. I am fine with doing that as a separate change. -- To view, visit http://gerrit.cloudera.org:8080/21447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b0b16e269c70716962fc5ebb4ddca1e2cbe68a4 Gerrit-Change-Number: 21447 Gerrit-PatchSet: 8 Gerrit-Owner: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Reviewer: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Comment-Date: Wed, 29 May 2024 14:38:24 +0000 Gerrit-HasComments: Yes
