Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21447 )
Change subject: Add a benchmark for CBTree concurrent writes. ...................................................................... Patch Set 8: > (2 comments) > > I think it is cleaner to add it to benchmark suit in a separate > commit. > I checked the Jenkins runs. Only TSAN fails with tests other than > this file. > @Alexey, is this ok to override Jenkins results, or should I keep > updating until it passes? If none of the relevant tests fails, then it's better to override the pre-commit test results: there are many flaky tests, and it's hard to rely on when they all pass (flaky tests stats and retries should help with that). -- To view, visit http://gerrit.cloudera.org:8080/21447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b0b16e269c70716962fc5ebb4ddca1e2cbe68a4 Gerrit-Change-Number: 21447 Gerrit-PatchSet: 8 Gerrit-Owner: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Reviewer: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Comment-Date: Tue, 04 Jun 2024 14:04:28 +0000 Gerrit-HasComments: No
