Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 )
Change subject: KUDU-3580 the crash bug when run binaries on older CPU machines ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/21287/3/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/21287/3/thirdparty/build-thirdparty.sh@38 PS3, Line 38: # * PORTABLE - whether to build portable libraries, otherwise build native libraries. Portable > nit: lines too long Done http://gerrit.cloudera.org:8080/#/c/21287/3/thirdparty/build-thirdparty.sh@39 PS3, Line 39: # libraries may cause a slight performance degradation, it's recommend to disable > do we have some benchmark? it would be good to know how seriously performan The performance impact is very slight according to my test. I built the RocksDB 'db_bench' tool with the '-DPORTABLE' option enabled and disabled, built and run the 2 version of tools on the same machine, the result difference is very slight. The test is similar to our use case, random write and sequential read, key and value size is about 40 bytes. $ ./db_bench_no_portable -benchmarks=fillrandom,readseq -num=10000000 -key_size=40 -value_size=40 Set seed to 1716998816665800 because --seed was 0 Initializing RocksDB Options from the specified file Initializing RocksDB Options from command-line flags Integrated BlobDB: blob cache disabled RocksDB: version 7.7.3 Date: Wed May 29 16:06:56 2024 CPU: 32 * Intel(R) Xeon(R) Silver 4216 CPU @ 2.10GHz CPUCache: 22528 KB Keys: 40 bytes each (+ 0 bytes user-defined timestamp) Values: 40 bytes each (20 bytes after compression) Entries: 10000000 Prefix: 0 bytes Keys per prefix: 0 RawSize: 762.9 MB (estimated) FileSize: 572.2 MB (estimated) Write rate: 0 bytes/second Read rate: 0 ops/second Compression: Snappy Compression sampling rate: 0 Memtablerep: SkipListFactory Perf Level: 1 ------------------------------------------------ Initializing RocksDB Options from the specified file Initializing RocksDB Options from command-line flags Integrated BlobDB: blob cache disabled DB path: [/tmp/rocksdbtest-1000/dbbench] fillrandom : 5.374 micros/op 186089 ops/sec 53.738 seconds 10000000 operations; 14.2 MB/s DB path: [/tmp/rocksdbtest-1000/dbbench] readseq : 0.445 micros/op 2246370 ops/sec 2.813 seconds 6319947 operations; 171.4 MB/s v.s. $ ./db_bench_portable -benchmarks=fillrandom,readseq -num=10000000 -key_size=40 -value_size=40 Set seed to 1716999023418616 because --seed was 0 Initializing RocksDB Options from the specified file Initializing RocksDB Options from command-line flags Integrated BlobDB: blob cache disabled RocksDB: version 7.7.3 Date: Wed May 29 16:10:23 2024 CPU: 32 * Intel(R) Xeon(R) Silver 4216 CPU @ 2.10GHz CPUCache: 22528 KB Keys: 40 bytes each (+ 0 bytes user-defined timestamp) Values: 40 bytes each (20 bytes after compression) Entries: 10000000 Prefix: 0 bytes Keys per prefix: 0 RawSize: 762.9 MB (estimated) FileSize: 572.2 MB (estimated) Write rate: 0 bytes/second Read rate: 0 ops/second Compression: Snappy Compression sampling rate: 0 Memtablerep: SkipListFactory Perf Level: 1 ------------------------------------------------ Initializing RocksDB Options from the specified file Initializing RocksDB Options from command-line flags Integrated BlobDB: blob cache disabled DB path: [/tmp/rocksdbtest-1000/dbbench] fillrandom : 5.321 micros/op 187944 ops/sec 53.207 seconds 10000000 operations; 14.3 MB/s DB path: [/tmp/rocksdbtest-1000/dbbench] readseq : 0.445 micros/op 2245913 ops/sec 2.815 seconds 6321780 operations; 171.3 MB/s -- To view, visit http://gerrit.cloudera.org:8080/21287 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id30ae995c41a592fccbdb822bc1f457c5e6878ac Gerrit-Change-Number: 21287 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Wed, 29 May 2024 16:23:54 +0000 Gerrit-HasComments: Yes
