KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/21356 )
Change subject: [metrics] Add metrics for tablet copy op time ...................................................................... Patch Set 11: (7 comments) Thanks for your reviews. http://gerrit.cloudera.org:8080/#/c/21356/10/src/kudu/tablet/tablet_metrics.h File src/kudu/tablet/tablet_metrics.h: http://gerrit.cloudera.org:8080/#/c/21356/10/src/kudu/tablet/tablet_metrics.h@114 PS10, Line 114: tablet_copy_duration; > nit: the details are available in the description of the metric (and it's p Done http://gerrit.cloudera.org:8080/#/c/21356/10/src/kudu/tablet/tablet_metrics.cc File src/kudu/tablet/tablet_metrics.cc: http://gerrit.cloudera.org:8080/#/c/21356/10/src/kudu/tablet/tablet_metrics.cc@255 PS10, Line 255: tablet_copy_duration, > nit: the details are available in the description, so this could be just Done http://gerrit.cloudera.org:8080/#/c/21356/10/src/kudu/tablet/tablet_metrics.cc@256 PS10, Line 256: Tablet Copy Duration", > nit: the details are available in the description, so this could be just Done http://gerrit.cloudera.org:8080/#/c/21356/10/src/kudu/tablet/tablet_metrics.cc@258 PS10, Line 258: Duration of tablet copying when using this tablet replica > Duration of tablet copying when using this tablet replica as a source. Done http://gerrit.cloudera.org:8080/#/c/21356/8/src/kudu/tserver/tablet_copy_service-test.cc File src/kudu/tserver/tablet_copy_service-test.cc: http://gerrit.cloudera.org:8080/#/c/21356/8/src/kudu/tserver/tablet_copy_service-test.cc@237 PS8, Line 237: // Test the metric that tracks the duration of a tablet copy session at the source side. : TEST_F(TabletCopyMetricTest, TestRunTimeMetricFinishState) { : const auto before_cnt = CopyRunTime()->TotalCount(); : string session_id; : ASSERT_OK(DoBeginValidTabletCopySession(&session_id)); : : EndTabletCopySessionResponsePB resp; : RpcController controller; : ASSERT_OK(DoEndTabletCopySession(session_id, true, nullptr, &resp, &controller)); : > Yep, this makes sense. Do you mean verifying in the unit test that the count of the tablet_copy_duration metric corresponding to the shard generated by the copy is zero? http://gerrit.cloudera.org:8080/#/c/21356/10/src/kudu/tserver/tablet_copy_service-test.cc File src/kudu/tserver/tablet_copy_service-test.cc: http://gerrit.cloudera.org:8080/#/c/21356/10/src/kudu/tserver/tablet_copy_service-test.cc@237 PS10, Line 237: at the source > nit: at the source side Done http://gerrit.cloudera.org:8080/#/c/21356/10/src/kudu/tserver/tablet_copy_source_session.cc File src/kudu/tserver/tablet_copy_source_session.cc: http://gerrit.cloudera.org:8080/#/c/21356/10/src/kudu/tserver/tablet_copy_source_session.cc@512 PS10, Line 512: // Prevent core dumps during deletion in the > Is there any situaion when RemoteTabletCopySourceSession::UpdateTabletMetri It leads core down in TsTabletManagerITest.TestDeleteTableDuringTabletCopy, so it is necessary to avoid the impact of deletion operations during the copying process. -- To view, visit http://gerrit.cloudera.org:8080/21356 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I088f6a9a8a07ad39ca95ae8b4995ce00d1a0d00c Gerrit-Change-Number: 21356 Gerrit-PatchSet: 11 Gerrit-Owner: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Thu, 30 May 2024 09:03:14 +0000 Gerrit-HasComments: Yes
