Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21356 )
Change subject: [metrics] Add metrics for tablet copy op time ...................................................................... Patch Set 13: Code-Review+1 (2 comments) Just one tiny need and the patch should be good to go! http://gerrit.cloudera.org:8080/#/c/21356/13/src/kudu/integration-tests/tablet_copy-itest.cc File src/kudu/integration-tests/tablet_copy-itest.cc: http://gerrit.cloudera.org:8080/#/c/21356/13/src/kudu/integration-tests/tablet_copy-itest.cc@152 PS13, Line 152: METRIC_DECLARE_histogram(tablet_copy_source_duration); : METRIC_DECLARE_histogram(tablet_copy_duration); nit: swap these two lines to make them alphabetically ordered, as the rest of this metrics list http://gerrit.cloudera.org:8080/#/c/21356/11/src/kudu/tablet/tablet_metrics.cc File src/kudu/tablet/tablet_metrics.cc: http://gerrit.cloudera.org:8080/#/c/21356/11/src/kudu/tablet/tablet_metrics.cc@258 PS11, Line 258: o CLIENT_PROPAGATED.", > Hi Alexey, Hi KeDeng, Thanks a lot for addressing the feedback and revving the patch! To me, the new version looks much better. -- To view, visit http://gerrit.cloudera.org:8080/21356 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I088f6a9a8a07ad39ca95ae8b4995ce00d1a0d00c Gerrit-Change-Number: 21356 Gerrit-PatchSet: 13 Gerrit-Owner: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Wed, 05 Jun 2024 21:33:15 +0000 Gerrit-HasComments: Yes
