KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/21356 )
Change subject: [metrics] Add metrics for tablet copy op time ...................................................................... Patch Set 14: (1 comment) Thanks for your reviews. http://gerrit.cloudera.org:8080/#/c/21356/13/src/kudu/integration-tests/tablet_copy-itest.cc File src/kudu/integration-tests/tablet_copy-itest.cc: http://gerrit.cloudera.org:8080/#/c/21356/13/src/kudu/integration-tests/tablet_copy-itest.cc@152 PS13, Line 152: METRIC_DECLARE_histogram(tablet_copy_duration); : METRIC_DECLARE_histogram(tablet_copy_source_dur > nit: swap these two lines to make them alphabetically ordered, as the rest Done -- To view, visit http://gerrit.cloudera.org:8080/21356 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I088f6a9a8a07ad39ca95ae8b4995ce00d1a0d00c Gerrit-Change-Number: 21356 Gerrit-PatchSet: 14 Gerrit-Owner: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Thu, 06 Jun 2024 02:16:50 +0000 Gerrit-HasComments: Yes