Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21536 )
Change subject: [Tool] Retry failed table copying tasks ...................................................................... Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/21536/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21536/6//COMMIT_MSG@9 PS6, Line 9: Copying a table with a large data maybe some tasks failed : because of timeout or memory pressure and so on. > nit: Copying a table with large data may cause some tasks to fail due to ti Done http://gerrit.cloudera.org:8080/#/c/21536/6//COMMIT_MSG@11 PS6, Line 11: ideal > nit: idea Done http://gerrit.cloudera.org:8080/#/c/21536/6/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/21536/6/src/kudu/tools/table_scanner.cc@146 PS6, Line 146: copy_task_fail_for_test > Mark it unsafe Done http://gerrit.cloudera.org:8080/#/c/21536/6/src/kudu/tools/table_scanner.cc@147 PS6, Line 147: Make copy task fail, just for test. > If true, fails the copy task. For use in test only. Done http://gerrit.cloudera.org:8080/#/c/21536/6/src/kudu/tools/table_scanner.cc@644 PS6, Line 644: retries over limitation > nit: Maybe make it more readable by: Done http://gerrit.cloudera.org:8080/#/c/21536/6/src/kudu/tools/table_scanner.cc@650 PS6, Line 650: retry_times_count++ > Ignore this. Didn't check it was pass by value. Done -- To view, visit http://gerrit.cloudera.org:8080/21536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I712201178c1b34e5e14256063b66f0008fdc6007 Gerrit-Change-Number: 21536 Gerrit-PatchSet: 6 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Reviewer: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Comment-Date: Mon, 15 Jul 2024 07:57:30 +0000 Gerrit-HasComments: Yes
