KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/21613 )
Change subject: [log] Support logging audit logs to a separate file ...................................................................... Patch Set 4: (2 comments) Thanks for your reviews. http://gerrit.cloudera.org:8080/#/c/21613/3/src/kudu/master/audit_logger.cc File src/kudu/master/audit_logger.cc: http://gerrit.cloudera.org:8080/#/c/21613/3/src/kudu/master/audit_logger.cc@63 PS3, Line 63: auto l = make_unique<RollingLog>(Env::Default(), log_dir_, program_name_, "AuditLog"); > nit: Now that there is a following `make_unique`, it's duplciate, this can Done http://gerrit.cloudera.org:8080/#/c/21613/3/src/kudu/master/audit_logger.cc@100 PS3, Line 100: oss.fill('0'); > Could you please add some log sample to the commit message? It would be hel Done -- To view, visit http://gerrit.cloudera.org:8080/21613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5323361befb456d91a12da7273865542f1d2430 Gerrit-Change-Number: 21613 Gerrit-PatchSet: 4 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 07 Aug 2024 09:56:13 +0000 Gerrit-HasComments: Yes
