KeDeng has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21613 )

Change subject: [log] Support logging audit logs to a separate file
......................................................................


Patch Set 5:

(2 comments)

Thanks for your reviews.

http://gerrit.cloudera.org:8080/#/c/21613/4/src/kudu/master/audit_logger.h
File src/kudu/master/audit_logger.h:

http://gerrit.cloudera.org:8080/#/c/21613/4/src/kudu/master/audit_logger.h@43
PS4, Line 43: Usage:
> Thanks for the update, but I meant add these descriptions to the commit mes
Done


http://gerrit.cloudera.org:8080/#/c/21613/4/src/kudu/master/audit_logger.h@70
PS4, Line 70: The other log file
> nit: What is the audit log file name looks like? Please add it to the descr
Done



--
To view, visit http://gerrit.cloudera.org:8080/21613
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5323361befb456d91a12da7273865542f1d2430
Gerrit-Change-Number: 21613
Gerrit-PatchSet: 5
Gerrit-Owner: KeDeng <[email protected]>
Gerrit-Reviewer: KeDeng <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Thu, 08 Aug 2024 09:16:10 +0000
Gerrit-HasComments: Yes

Reply via email to