Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21661 )
Change subject: KUDU-3543: Add JSON Content-Type Header ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21661/1//COMMIT_MSG Commit Message: PS1: There are a few more handlers that de-facto output application/json pages: * /jwks.json, /jwks/$account_id, /.well-known/openid-configuration in src/kudu/util/mini-oidc.cc * /dump-entities in src/kudu/master/master_path_handlers.cc Do you think it makes sense to updated those as well as a part of this changelist? http://gerrit.cloudera.org:8080/#/c/21661/1/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/21661/1/src/kudu/server/webserver.cc@751 PS1, Line 751: case StyleMode::UNSTYLED: : content_type = "text/plain"; Since this is going to apply to any page (even for the newly marked as JSON in this patch) when supplying 'raw' parameter in the URL of the HTTP request, maybe at some point it makes sense to revisit the registration of other endpoints and probably separate the original semantics of the StyleMode enum (i.e. whether to feed through mustache template or not) and the newly added content-type semantics. It's better to do so in a separate changelist, I guess. -- To view, visit http://gerrit.cloudera.org:8080/21661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829 Gerrit-Change-Number: 21661 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 12 Aug 2024 23:45:27 +0000 Gerrit-HasComments: Yes
