Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21661 )
Change subject: KUDU-3543: Add JSON Content-Type Header ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21661/1//COMMIT_MSG Commit Message: PS1: > There are a few more handlers that de-facto output application/json pages: Thanks for double checking the endpoints, good catch! Added those mentioned. MiniOidc is in my understantind test infrastructure therefore opted not to write explicit tests to check the content-type header values on those endpoints. The Json handler’s functionality is basically validated in the master&tserver tests. However if you feel like we should add content-type header tests to MiniOidc, I can follow up. http://gerrit.cloudera.org:8080/#/c/21661/1/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/21661/1/src/kudu/server/webserver.cc@751 PS1, Line 751: case StyleMode::UNSTYLED: : content_type = "text/plain"; > Since this is going to apply to any page (even for the newly marked as JSON Yepp this is valid. Created a jira to track this improvement: KUDU-3609. Thanks for bringing this to my attention! -- To view, visit http://gerrit.cloudera.org:8080/21661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37b442cb3e8be68f7b243e66ed5ebe369df07829 Gerrit-Change-Number: 21661 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 16 Aug 2024 10:56:40 +0000 Gerrit-HasComments: Yes
