Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21634 )
Change subject: Table copy supports creating a table with no range partition ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/21634/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21634/2//COMMIT_MSG@11 PS2, Line 11: unbounded > nit: unbounded Done http://gerrit.cloudera.org:8080/#/c/21634/2//COMMIT_MSG@43 PS2, Line 43: Semantically it is right, but is > Semantically it's right, but it is better to keep the source table schema t Done http://gerrit.cloudera.org:8080/#/c/21634/2/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/21634/2/src/kudu/tools/kudu-tool-test.cc@1870 PS2, Line 1870: Other than the table names, the schemas are the same. > nit: Other than the table names, the schemas are the same. Done http://gerrit.cloudera.org:8080/#/c/21634/2/src/kudu/tools/kudu-tool-test.cc@1871 PS2, Line 1871: Therefore > nit: add comma after Therefore Done. Thanks for your comments. -- To view, visit http://gerrit.cloudera.org:8080/21634 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94f99f845393ff2460761cc7bd82ecb3f3ead79b Gerrit-Change-Number: 21634 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 21 Aug 2024 07:14:07 +0000 Gerrit-HasComments: Yes
