Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21634 )
Change subject: Table copy supports creating a table with no range partition ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21634/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/21634/3/src/kudu/tools/kudu-tool-test.cc@1833 PS3, Line 1833: break; nit: Add a check to clarify the logic. Other places are the same. default: ASSERT_TRUE(false); http://gerrit.cloudera.org:8080/#/c/21634/3/src/kudu/tools/kudu-tool-test.cc@1867 PS3, Line 1867: nit: alignment. -- To view, visit http://gerrit.cloudera.org:8080/21634 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94f99f845393ff2460761cc7bd82ecb3f3ead79b Gerrit-Change-Number: 21634 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 21 Aug 2024 16:05:50 +0000 Gerrit-HasComments: Yes
