Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21816 )

Change subject: KUDU-3604: Pin Cython Version, Package Maintenance
......................................................................


Patch Set 2:

(1 comment)

One more question after looking this a bit closer.

Thank you for working on this!

http://gerrit.cloudera.org:8080/#/c/21816/2/python/setup_prerequisites.py
File python/setup_prerequisites.py:

http://gerrit.cloudera.org:8080/#/c/21816/2/python/setup_prerequisites.py@44
PS2, Line 44: pkg_resources.VersionConflict
Just curious: how this is going to work if Cython of different version is 
installed?  I guess that would result in this VersionConflict exception, but 
would pip install be able to install the required version given that some other 
version is already present?

If that situation would require manual intervention anyways, then what's the 
point of these changes besides splitting the development and run-time 
dependencies?



--
To view, visit http://gerrit.cloudera.org:8080/21816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45ad45c56fc3f3ecf57a413edbd0866fccbd8f79
Gerrit-Change-Number: 21816
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <greber...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <greber...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com>
Gerrit-Comment-Date: Fri, 27 Sep 2024 17:24:58 +0000
Gerrit-HasComments: Yes

Reply via email to