Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22338 )
Change subject: [compaction] Release delta blocks memory early to avoid more consumption. ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/22338/3/src/kudu/tablet/deltafile.h File src/kudu/tablet/deltafile.h: http://gerrit.cloudera.org:8080/#/c/22338/3/src/kudu/tablet/deltafile.h@271 PS3, Line 271: delta_blocks_.clear(); > I am not sure what you mean by that. That's something similar to many other places that you could find in the code base: various DCHECK assertions to enforce invariants (e.g., the legality of state transitions, making sure a lock primitive is acquired accessing data that is guarded by it, etc.). The ask was to put together a simple set of criteria to make sure that 'delta_blocks_' container isn't accessed mistakenly when it has been emptied already. The goal was to protect against mistakes in future modifications/refactoring of this code. OK, if that's too hard to do or you think it doesn't make much sense, then let's skip this then. -- To view, visit http://gerrit.cloudera.org:8080/22338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c1eadcb8ad735fc92ac77f554934e606e4119ae Gerrit-Change-Number: 22338 Gerrit-PatchSet: 4 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 18 Mar 2025 14:51:42 +0000 Gerrit-HasComments: Yes
