Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22338 )
Change subject: [compaction] Release delta blocks memory early to avoid more consumption. ...................................................................... [compaction] Release delta blocks memory early to avoid more consumption. MajorDelta compaction relies on object scope to release the memory used to store delta blocks that are read during the PrepareBatch phase of the compaction operation. The use of delta blocks is till the point when REDO mutations are applied to base data and corresponding UNDO mutations are created for each REDO mutation. This patch releases the memory as soon as compaction is done using delta blocks. This will avoid unnecessary pressure on memory for the rest of the compaction operation. This is also a precursor to MajorDelta chunked compaction work. Change-Id: I0c1eadcb8ad735fc92ac77f554934e606e4119ae Reviewed-on: http://gerrit.cloudera.org:8080/22338 Tested-by: Kudu Jenkins Reviewed-by: Attila Bukor <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/tablet/delta_compaction.cc M src/kudu/tablet/delta_iterator_merger.cc M src/kudu/tablet/delta_iterator_merger.h M src/kudu/tablet/delta_store.h M src/kudu/tablet/deltafile.cc M src/kudu/tablet/deltafile.h M src/kudu/tablet/deltamemstore.h 7 files changed, 28 insertions(+), 1 deletion(-) Approvals: Kudu Jenkins: Verified Attila Bukor: Looks good to me, but someone else must approve Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/22338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0c1eadcb8ad735fc92ac77f554934e606e4119ae Gerrit-Change-Number: 22338 Gerrit-PatchSet: 5 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]>
