Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22730 )
Change subject: [integration-tests] fix result status handling ...................................................................... [integration-tests] fix result status handling This patch addresses sloppy result handling of functions/methods that return Status under the src/kudu/integration-tests directory. After I added proper result status handling, I found that the ScanYourWritesMultiClientsParamTest.Test scenario in consistency-itest wasn't doing what it was supposed to do. I added a TODO blurb to be addressed later a separate changelist because it's not trivial. My goal for this changelist is to fix result status handling, and maybe address trivial underlying bugs and issues that might be lurking there due to sloppy result status handling. However, addressing a non-trivial bug or rewriting a test should be taken care of in a separate changelist. Change-Id: I09f0266063d5e6b02c668237047cdea04c6911a7 Reviewed-on: http://gerrit.cloudera.org:8080/22730 Tested-by: Kudu Jenkins Reviewed-by: Marton Greber <[email protected]> Reviewed-by: Zoltan Martonka <[email protected]> --- M src/kudu/integration-tests/all_types-itest.cc M src/kudu/integration-tests/alter_table-randomized-test.cc M src/kudu/integration-tests/alter_table-test.cc M src/kudu/integration-tests/authz_token-itest.cc M src/kudu/integration-tests/auto_incrementing-itest.cc M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/consistency-itest.cc M src/kudu/integration-tests/create-table-itest.cc M src/kudu/integration-tests/delete_table-itest.cc M src/kudu/integration-tests/delete_tablet-itest.cc M src/kudu/integration-tests/dense_node-itest.cc M src/kudu/integration-tests/exactly_once_writes-itest.cc M src/kudu/integration-tests/flex_partitioning-itest.cc M src/kudu/integration-tests/heavy-update-compaction-itest.cc M src/kudu/integration-tests/linked_list-test.cc M src/kudu/integration-tests/master_hms-itest.cc M src/kudu/integration-tests/memory_gc-itest.cc M src/kudu/integration-tests/multidir_cluster-itest.cc M src/kudu/integration-tests/open-readonly-fs-itest.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/integration-tests/raft_consensus_stress-itest.cc M src/kudu/integration-tests/registration-test.cc M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/integration-tests/tombstoned_voting-imc-itest.cc M src/kudu/integration-tests/ts_itest-base.cc M src/kudu/integration-tests/ts_itest-base.h M src/kudu/integration-tests/txn_commit-itest.cc M src/kudu/integration-tests/txn_write_ops-itest.cc M src/kudu/integration-tests/version_migration-test.cc M src/kudu/integration-tests/write_limit-itest.cc M src/kudu/tools/kudu-admin-test.cc 32 files changed, 214 insertions(+), 152 deletions(-) Approvals: Kudu Jenkins: Verified Marton Greber: Looks good to me, approved Zoltan Martonka: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/22730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I09f0266063d5e6b02c668237047cdea04c6911a7 Gerrit-Change-Number: 22730 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]>
