Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22730 )
Change subject: [integration-tests] fix result status handling ...................................................................... Patch Set 3: (1 comment) Thank you for reviews! http://gerrit.cloudera.org:8080/#/c/22730/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc File src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc: http://gerrit.cloudera.org:8080/#/c/22730/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@1810 PS3, Line 1810: Status add_server_status; : std::thread t([&] { : add_server_status = AddServer( : leader, tablet_id, new_replica, RaftPeerPB::NON_VOTER, kTimeout); : }); > Just out of curiosity, why are we starting a separate thread and wait for i That's a good point. Yes, I think it would be possible to call AddServer() in the main test thread. If necessary, we can address that in a separate changelist. We aren't literally waiting for the thread to complete right after, but rather adding a means to join the thread once the test completes by means of using SCOPED_CLEANUP. I guess the idea was to have a separate thread doing this so the main test thread could monitor the consensus state while 'AddServer' progresses. However, I might be missing something. That's the reason why I didn't change this and similar issues in this patch: this patch is focusing on handling result status. -- To view, visit http://gerrit.cloudera.org:8080/22730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09f0266063d5e6b02c668237047cdea04c6911a7 Gerrit-Change-Number: 22730 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Fri, 04 Apr 2025 15:59:36 +0000 Gerrit-HasComments: Yes
