Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24134 )
Change subject: [fs] fix partial blocks deletion case in rocksdb ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/24134/2/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/24134/2/src/kudu/fs/log_block_manager-test.cc@2896 PS2, Line 2896: constexpr int kBatchSize = 5; : constexpr int kCommittedBlocks = kBatchSize; // first batch: blocks [0..4] : constexpr int kUncommittedBlocks = kBatchSize; // second batch: blocks [5..9] : constexpr int kTotalBlocks = kCommittedBlocks + kUncommittedBlocks; / > nit: make these constexpr? Done http://gerrit.cloudera.org:8080/#/c/24134/2/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/24134/2/src/kudu/fs/log_block_manager.cc@133 PS2, Line 133: If the value is non-zero > Any special meaning for a negative value of this flag? Not really. Changed to uint32. http://gerrit.cloudera.org:8080/#/c/24134/2/src/kudu/fs/log_block_manager.cc@2126 PS2, Line 2126: siz > nit: consider using size_t for counters like this Done -- To view, visit http://gerrit.cloudera.org:8080/24134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb553fbf9a88f0cdb392f926289bbdf5f18b5d29 Gerrit-Change-Number: 24134 Gerrit-PatchSet: 3 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 31 Mar 2026 15:22:10 +0000 Gerrit-HasComments: Yes
