Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/24127 )
Change subject: [examples] add replication demo ...................................................................... Patch Set 3: (4 comments) I went through the files, but I'd still like to do some manual testing, until then a few small nits http://gerrit.cloudera.org:8080/#/c/24127/3/examples/flink-replication/.env File examples/flink-replication/.env: http://gerrit.cloudera.org:8080/#/c/24127/3/examples/flink-replication/.env@24 PS3, Line 24: KUDU_VERSION=1.18.1-ubuntu maybe add a note to the RELEASING.adoc document, that this version also needs to be updated when updating the kudu version in the examples, this might not be as obvious as the poms http://gerrit.cloudera.org:8080/#/c/24127/3/examples/flink-replication/docker-compose.yml File examples/flink-replication/docker-compose.yml: http://gerrit.cloudera.org:8080/#/c/24127/3/examples/flink-replication/docker-compose.yml@314 PS3, Line 314: latest would it make sense to pin the prometheus version as well? e.g. a major release might break apis http://gerrit.cloudera.org:8080/#/c/24127/3/examples/flink-replication/flink/submit-job.sh File examples/flink-replication/flink/submit-job.sh: http://gerrit.cloudera.org:8080/#/c/24127/3/examples/flink-replication/flink/submit-job.sh@68 PS3, Line 68: echo " Source master : ${SRC_MASTER}" : echo " Sink master : ${SINK_MASTER}" nit, formatting? why the extra whitespaces for these two lines? http://gerrit.cloudera.org:8080/#/c/24127/3/examples/flink-replication/monitoring/prometheus.yml File examples/flink-replication/monitoring/prometheus.yml: http://gerrit.cloudera.org:8080/#/c/24127/3/examples/flink-replication/monitoring/prometheus.yml@79 PS3, Line 79: → nit: unicode :') -- To view, visit http://gerrit.cloudera.org:8080/24127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebf29efaebc91d9831f57fc884a2acbab31715ce Gerrit-Change-Number: 24127 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 01 Apr 2026 09:19:18 +0000 Gerrit-HasComments: Yes
