Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/24127 )
Change subject: [examples] add replication demo ...................................................................... Patch Set 4: Code-Review+1 (9 comments) small cleanup bits, otherwise this looks good, I also tested it locally and works as expected http://gerrit.cloudera.org:8080/#/c/24127/4/examples/flink-replication/Makefile File examples/flink-replication/Makefile: http://gerrit.cloudera.org:8080/#/c/24127/4/examples/flink-replication/Makefile@110 PS4, Line 110: apache/kudu:kudu-python-latest-ubuntu this version is pinned in the envfile as kudu-python-1.18.1-ubuntu, maybe update this comment? http://gerrit.cloudera.org:8080/#/c/24127/4/examples/flink-replication/docker-compose.yml File examples/flink-replication/docker-compose.yml: http://gerrit.cloudera.org:8080/#/c/24127/4/examples/flink-replication/docker-compose.yml@268 PS4, Line 268: kudu:kudu-python-latest-ubuntu. update to kudu-python-1.18.1-ubuntu http://gerrit.cloudera.org:8080/#/c/24127/4/examples/flink-replication/docker-compose.yml@329 PS4, Line 329: grafana/grafana:latest maybe this should be pinned too? along with the json-exporter as well http://gerrit.cloudera.org:8080/#/c/24127/4/examples/flink-replication/flink/submit-job.sh File examples/flink-replication/flink/submit-job.sh: http://gerrit.cloudera.org:8080/#/c/24127/4/examples/flink-replication/flink/submit-job.sh@29 PS4, Line 29: # DISCOVERY_INTERVAL_SECONDS KuduSource diff-scan period (default: 30) : # CHECKPOINT_INTERVAL_MS Flink checkpoint interval (default: 10000) these defaults are correct when there is no .env file, however they are declared as 10 / 5000 there, and the README references these latter values: https://gerrit.cloudera.org/c/24127/4/examples/flink-replication/README.md#225 it would probably avoid confusion if these values were synced up, either here or in the readme http://gerrit.cloudera.org:8080/#/c/24127/4/examples/flink-replication/ingest/ingest.py File examples/flink-replication/ingest/ingest.py: http://gerrit.cloudera.org:8080/#/c/24127/4/examples/flink-replication/ingest/ingest.py@41 PS4, Line 41: 4 buckets this comment declares 4 buckets, however NUM_PARTITIONS is declared as 16 at line#92 http://gerrit.cloudera.org:8080/#/c/24127/4/examples/flink-replication/ingest/ingest.py@264 PS4, Line 264: ("INSERT_RATE", 0.5)), this doesn't match line #50: INSERT_RATE relative weight for INSERT ops (default: 0.4) http://gerrit.cloudera.org:8080/#/c/24127/4/examples/flink-replication/ingest/ingest.py@270 PS4, Line 270: ("UPDATE_RATE", 0.3)), this doesn't match line #51: UPDATE_RATE relative weight for UPDATE ops (default: 0.2) http://gerrit.cloudera.org:8080/#/c/24127/4/examples/flink-replication/monitoring/prometheus.yml File examples/flink-replication/monitoring/prometheus.yml: http://gerrit.cloudera.org:8080/#/c/24127/4/examples/flink-replication/monitoring/prometheus.yml@22 PS4, Line 22: make monitoring-up there is no monitoring-up target in the makefile, also the docker-compose.yml doesn't have a "monitoring" profile http://gerrit.cloudera.org:8080/#/c/24127/4/examples/flink-replication/scripts/ready.sh File examples/flink-replication/scripts/ready.sh: http://gerrit.cloudera.org:8080/#/c/24127/4/examples/flink-replication/scripts/ready.sh@26 PS4, Line 26: make ready the makefile doesn't have a ready target -- To view, visit http://gerrit.cloudera.org:8080/24127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebf29efaebc91d9831f57fc884a2acbab31715ce Gerrit-Change-Number: 24127 Gerrit-PatchSet: 4 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 07 Apr 2026 09:23:39 +0000 Gerrit-HasComments: Yes
