Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24157 )
Change subject: Fix misleading Javadoc for writer.maxBufferSize ...................................................................... Fix misleading Javadoc for writer.maxBufferSize The Javadoc for writer.maxBufferSize incorrectly described it as "maximum size in bytes of the client-side write buffer". It actually maps to KuduSession's mutationBufferMaxOps, which is a count of buffered mutation operations, not a byte size. The confusion likely stems from the parameter name in the Flink connector (KuduWriterConfig.maxBufferSize), which implies a byte quantity, while the connector's own source comment clarifies: "Reference from AsyncKuduSession mutationBufferMaxOps 1000." Change-Id: I2e79b888ecc4bd0ef815aeadec9003027b7d6b3a Reviewed-on: http://gerrit.cloudera.org:8080/24157 Reviewed-by: Ashwani Raina <[email protected]> Tested-by: Marton Greber <[email protected]> Reviewed-by: Zoltan Chovan <[email protected]> --- M java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationConfigParser.java M java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Ashwani Raina: Looks good to me, but someone else must approve Marton Greber: Verified Zoltan Chovan: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/24157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2e79b888ecc4bd0ef815aeadec9003027b7d6b3a Gerrit-Change-Number: 24157 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]>
