Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24269 )
Change subject: KUDU-3690: Add filtering to /metrics_prometheus ...................................................................... Patch Set 6: Code-Review+1 (2 comments) LGTM! Just a couple of nits. http://gerrit.cloudera.org:8080/#/c/24269/6/src/kudu/server/default_path_handlers.cc File src/kudu/server/default_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/24269/6/src/kudu/server/default_path_handlers.cc@499 PS6, Line 499: resp->status_code = HttpStatusCode::BadRequest; : resp->output << "The 'attributes' parameter must be provided as key-value pairs " : "(i.e. an even number of values)"; nit: Does it make sense to set Content-Type as well for clients as a standard practice? http://gerrit.cloudera.org:8080/#/c/24269/6/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/24269/6/src/kudu/tserver/tablet_server-test.cc@4511 PS6, Line 4511: str Here and below: Would it make sense to have a sanity check (CheckPrometheusOutput) here? -- To view, visit http://gerrit.cloudera.org:8080/24269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c0b23ae5c184bf9e33e453736cef5e7ce8ee2e1 Gerrit-Change-Number: 24269 Gerrit-PatchSet: 6 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 12 May 2026 06:13:23 +0000 Gerrit-HasComments: Yes
