Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24269 )
Change subject: KUDU-3690: Add filtering to /metrics_prometheus ...................................................................... KUDU-3690: Add filtering to /metrics_prometheus The /metrics_prometheus endpoint now accepts the same query parameters as the /metrics JSON endpoint for filtering: ?level= severity threshold (debug/info/warn) ?types= entity type (server/tablet/table) ?ids= entity ID substring ?metrics= metric name substring ?attributes= key/value pairs for entity attribute matching Malformed ?attributes= (odd number of values) returns HTTP 400, mirroring the existing JSON endpoint behaviour. Change-Id: I5c0b23ae5c184bf9e33e453736cef5e7ce8ee2e1 Reviewed-on: http://gerrit.cloudera.org:8080/24269 Reviewed-by: Zoltan Chovan <[email protected]> Reviewed-by: Ashwani Raina <[email protected]> Tested-by: Marton Greber <[email protected]> --- M src/kudu/master/master-test.cc M src/kudu/server/default_path_handlers.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/util/metrics-test.cc M src/kudu/util/metrics.h M src/kudu/util/prometheus_writer.cc M src/kudu/util/test_util.cc M src/kudu/util/test_util.h 8 files changed, 816 insertions(+), 24 deletions(-) Approvals: Zoltan Chovan: Looks good to me, approved Ashwani Raina: Looks good to me, but someone else must approve Marton Greber: Verified -- To view, visit http://gerrit.cloudera.org:8080/24269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5c0b23ae5c184bf9e33e453736cef5e7ce8ee2e1 Gerrit-Change-Number: 24269 Gerrit-PatchSet: 8 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]>
