Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24475
Change subject: KUDU-3785: Fix CLI flag validator failure ...................................................................... KUDU-3785: Fix CLI flag validator failure A customer issue was discovered during rolling restarts where the tserver flagfile is passed to CLI commands (e.g. kudu fs dump --flagfile=tserver.flags). The CLI sets rpc_max_message_size to ~2GB via SET_FLAGS_DEFAULT to accommodate large responses. Previously, tablet_transaction_memory_limit_mb was also set via SET_FLAGS_DEFAULT to satisfy the GROUP_FLAG_VALIDATOR in op_tracker.cc (see https://gerrit.cloudera.org/#/c/20535/). However, SET_FLAGS_DEFAULT has lowest priority, so a flagfile overriding tablet_transaction_memory_limit_mb (e.g. to 256MB) triggers the validator: 256MB < 2GB -> failure. The CLI tool does not host tablets, so the transaction memory limit is irrelevant. The fix sets tablet_transaction_memory_limit_mb to -1 using SET_FLAGS_VALUE after flag parsing, which disables the validator check entirely for the CLI process regardless of flagfile contents. A regression test is added that reproduces the scenario by passing a flagfile with a low tablet_transaction_memory_limit_mb value and verifying the tool exits cleanly without the validator error. Change-Id: Idd24ec605bd14ce90ed8a5705230ff96d77d0d64 --- M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_main.cc 2 files changed, 41 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/24475/1 -- To view, visit http://gerrit.cloudera.org:8080/24475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Idd24ec605bd14ce90ed8a5705230ff96d77d0d64 Gerrit-Change-Number: 24475 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]>
