Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24475 )
Change subject: KUDU-3785: Fix CLI flag validator failure ...................................................................... Patch Set 1: (1 comment) Thanks for fixing this. Looks good to me. Just one nit. http://gerrit.cloudera.org:8080/#/c/24475/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/24475/1/src/kudu/tools/kudu-tool-test.cc@11121 PS1, Line 11121: RunKuduTool nit: For the purpose of clear demonstration, maybe add another case where --rpc_max_message_size is explicitly set here in CLI along with flagfile_path that contains --tablet_transaction_memory_limit_mb set to a different value. -- To view, visit http://gerrit.cloudera.org:8080/24475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd24ec605bd14ce90ed8a5705230ff96d77d0d64 Gerrit-Change-Number: 24475 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 16 Jun 2026 13:14:28 +0000 Gerrit-HasComments: Yes
