Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24475 )
Change subject: KUDU-3785: Fix CLI flag validator failure ...................................................................... Patch Set 3: > Thanks for the suggestion! I considered the coordinated > SET_FLAGS_DEFAULT approach (only apply defaults if neither flag is > explicitly set), but went with moving the large message size into > BuildMessenger() instead. The reasoning: > > 1. The large RPC message size is purely a client-side concern — > only CLI tool messengers need it. Inflating a global flag (even as > a default) leaks a client detail into process-wide state, which is > what caused the layering issues in the first place. > > 2. BuildMessenger() is the single chokepoint for all CLI RPC > messengers, so it's the natural place to configure this. No flag > manipulation needed, no interaction with validators. > > 3. We still honor an explicit --rpc_max_message_size if the user > sets one — BuildMessenger() checks is_default and uses the flag > value when it's been explicitly set. > > 4. This eliminates the need to touch tablet_transaction_memory_limit_mb > at all — since the global rpc_max_message_size stays at its > compiled default (50MB), the GROUP_FLAG_VALIDATOR passes without > any workarounds. > > (Sorry about the pivot, first I thought a quick fix would be fine > and then I realised that yea we can probably do better.) Let me > know what you think about this approach! > > Thanks! Yes, I agree that limiting the context of the increased RPC maximum message size is a better approach for the CLI tools. All the items you mentioned make sense to me. Thank you! -- To view, visit http://gerrit.cloudera.org:8080/24475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd24ec605bd14ce90ed8a5705230ff96d77d0d64 Gerrit-Change-Number: 24475 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 18 Jun 2026 20:31:08 +0000 Gerrit-HasComments: No
