Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24475 )
Change subject: KUDU-3785: Fix CLI flag validator failure ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/24475/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/24475/3/src/kudu/tools/kudu-tool-test.cc@11136 PS3, Line 11136: without relying on global flag inflation. > Maybe, drop this part since it's no longer relevant: it's now confusing on Done http://gerrit.cloudera.org:8080/#/c/24475/3/src/kudu/tools/kudu-tool-test.cc@11141 PS3, Line 11141: ASSERT_OK(BuildMessenger("test", &messenger)); > Does it make sense to add an assertion on --rpc_max_message_size keeping i Done http://gerrit.cloudera.org:8080/#/c/24475/3/src/kudu/tools/kudu-tool-test.cc@11142 PS3, Line 11142: ASSERT_GT(messenger->rpc_max_message_size(), FLAGS_rpc_max_message_size); > nit: maybe, add a comment that this assumes the amount of available memory Done http://gerrit.cloudera.org:8080/#/c/24475/3/src/kudu/tools/kudu-tool-test.cc@11153 PS3, Line 11153: } > I'd think of reverting the customization of the --rpc_max_message_size sett Done http://gerrit.cloudera.org:8080/#/c/24475/3/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: http://gerrit.cloudera.org:8080/#/c/24475/3/src/kudu/tools/tool_action_common.cc@558 PS3, Line 558: if (google::GetCommandLineFlagInfoOrDie("rpc_max_message_size").is_default) { > Would this check work as expected if 'rpc_max_message_size' is set explicit yes, added comment here, and a small test too. -- To view, visit http://gerrit.cloudera.org:8080/24475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd24ec605bd14ce90ed8a5705230ff96d77d0d64 Gerrit-Change-Number: 24475 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 22 Jun 2026 13:28:56 +0000 Gerrit-HasComments: Yes
