Jeison Romero has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24545 )

Change subject: KUDU-3777: return HTTP 401 for bad SPNEGO headers
......................................................................


Patch Set 6:

Reworded the inline comment per Gabriella's feedback to explain the why rather 
than restate the code.

Found and fixed a related gap while addressing Attila's question: the 401 
response wasn't consistently including a WWW-Authenticate: Negotiate challenge 
header across all SPNEGO failure paths. Now every 401 from this handler 
includes it, so clients always get a clear signal to retry with Negotiate.

Updated SpnegoWebserverTest.TestInvalidHeaders, 
SpnegoRestCatalogTest.TestInvalidHeaders, and 
PrometheusTokenWebserverTest.TestInvalidSpnegoDeniedOnOtherPaths, which I 
previously missed, to assert on the presence of the header, and to reflect the 
corrected 401 status code in the paths this patch touches.

Let me know if it looks good to go.


--
To view, visit http://gerrit.cloudera.org:8080/24545
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1e85a991c50cddeec76a2ab16a65b34fe3fee5c
Gerrit-Change-Number: 24545
Gerrit-PatchSet: 6
Gerrit-Owner: Jeison Romero <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Jeison Romero <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Comment-Date: Thu, 09 Jul 2026 00:22:07 +0000
Gerrit-HasComments: No

Reply via email to