Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24545 )
Change subject: KUDU-3777: return HTTP 401 for bad SPNEGO headers ...................................................................... KUDU-3777: return HTTP 401 for bad SPNEGO headers When a client sends an Authorization header with an unrecognized scheme (e.g., Bearer) to a SPNEGO-protected webserver endpoint, RunSpnegoStep returns Status::InvalidArgument. Previously, the error dispatch in Webserver::BeginRequestCallback only mapped IsNotAuthorized() to HTTP 401, allowing InvalidArgument to fall through to an HTTP 500. This patch updates the error dispatch to map IsInvalidArgument() to HTTP 401 (Authentication Required), ensuring the correct client error is returned. The SpnegoWebserverTest.TestInvalidHeaders test has also been updated to expect the correct 401 response. Change-Id: Ie1e85a991c50cddeec76a2ab16a65b34fe3fee5c Reviewed-on: http://gerrit.cloudera.org:8080/24545 Tested-by: Kudu Jenkins Reviewed-by: Gabriella Lotz <[email protected]> Reviewed-by: Marton Greber <[email protected]> Reviewed-by: Attila Bukor <[email protected]> --- M src/kudu/master/spnego_rest_catalog-test.cc M src/kudu/server/webserver-test.cc M src/kudu/server/webserver.cc 3 files changed, 21 insertions(+), 12 deletions(-) Approvals: Kudu Jenkins: Verified Gabriella Lotz: Looks good to me, but someone else must approve Marton Greber: Looks good to me, but someone else must approve Attila Bukor: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/24545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie1e85a991c50cddeec76a2ab16a65b34fe3fee5c Gerrit-Change-Number: 24545 Gerrit-PatchSet: 10 Gerrit-Owner: Jeison Romero <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Jeison Romero <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]>
