Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/24613 )
Change subject: KUDU-3760 expose follower-move flag in rebalancer ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/24613/2/src/kudu/tools/rebalancer_tool-test.cc File src/kudu/tools/rebalancer_tool-test.cc: http://gerrit.cloudera.org:8080/#/c/24613/2/src/kudu/tools/rebalancer_tool-test.cc@795 PS2, Line 795: > q: this test guards that the CLI accepts the flag (an unregistered flag wou You're right, thanks for flagging. I've updated the comment above the test to say this explicitly so future readers don't over-trust it. http://gerrit.cloudera.org:8080/#/c/24613/2/src/kudu/tools/rebalancer_tool.cc File src/kudu/tools/rebalancer_tool.cc: http://gerrit.cloudera.org:8080/#/c/24613/2/src/kudu/tools/rebalancer_tool.cc@1346 PS2, Line 1346: deadline > nit: this changed `std::move(deadline)` to `deadline` (plain copy) while th Changed this because of clang-tidy: kudu/src/kudu/tools/rebalancer_tool.cc:1346:23: warning: std::move of the variable 'deadline' of the trivially-copyable type 'optional<kudu::MonoTime>' has no effect; remove std::move() [performance-move-const-arg] std::move(deadline)), ^~~~~~~~~~ ~ -- To view, visit http://gerrit.cloudera.org:8080/24613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f1b03da71b11af82f18ff9e20dcaa676b185645 Gerrit-Change-Number: 24613 Gerrit-PatchSet: 2 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 31 Jul 2026 08:51:59 +0000 Gerrit-HasComments: Yes
