Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24613 )

Change subject: KUDU-3760 expose follower-move flag in rebalancer
......................................................................


Patch Set 3:

(1 comment)

> Thank you! Did you have a chance to take a look at my comment about
 > src/kudu/tools/tool_action_cluster.cc?

+1: please add the newly added flag via AddOptionalParameter() into 
ClusterActionBuilder, so the CLI tool displays help for the parameter when 
requested.

http://gerrit.cloudera.org:8080/#/c/24613/3/src/kudu/tools/rebalancer_tool.cc
File src/kudu/tools/rebalancer_tool.cc:

http://gerrit.cloudera.org:8080/#/c/24613/3/src/kudu/tools/rebalancer_tool.cc@106
PS3, Line 106: rebalancing_
Since this flag is exposed only through 'kudu cluster rebalance' CLI, consider 
naming this simply 'prefer_follower_replica_moves'.  I assume there isn't a 
conflict with other flags defined elsewhere.



--
To view, visit http://gerrit.cloudera.org:8080/24613
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1b03da71b11af82f18ff9e20dcaa676b185645
Gerrit-Change-Number: 24613
Gerrit-PatchSet: 3
Gerrit-Owner: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Mon, 03 Aug 2026 18:27:56 +0000
Gerrit-HasComments: Yes

Reply via email to