Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24613 )
Change subject: KUDU-3760 expose follower-move flag in rebalancer ...................................................................... KUDU-3760 expose follower-move flag in rebalancer The follower-move preference added for the auto-rebalancer changed the default of TwoDimensionalGreedyAlgo's constructor to prefer follower moves. The CLI rebalance tool default-constructs that algorithm, so it started preferring follower moves silently, with no way to turn it off. Add a --prefer_follower_replica_moves flag (default true, to match both the auto-rebalancer's flag and the new constructor default) and plumb it through to the algorithm. This keeps the current behavior but makes it explicit and overridable from the command line. Adds a parameterized test that runs the tool with the flag set both ways and checks the cluster still ends up balanced. Change-Id: I5f1b03da71b11af82f18ff9e20dcaa676b185645 Reviewed-on: http://gerrit.cloudera.org:8080/24613 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/tools/rebalancer_tool-test.cc M src/kudu/tools/rebalancer_tool.cc M src/kudu/tools/tool_action_cluster.cc 3 files changed, 86 insertions(+), 2 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/24613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5f1b03da71b11af82f18ff9e20dcaa676b185645 Gerrit-Change-Number: 24613 Gerrit-PatchSet: 5 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]>
