Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24710 )
Change subject: KUDU-3788 introduce 'any' for OS, OS version, arch, toolchain ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/24710/1/thirdparty/prebuilt-utils.sh File thirdparty/prebuilt-utils.sh: http://gerrit.cloudera.org:8080/#/c/24710/1/thirdparty/prebuilt-utils.sh@192 PS1, Line 192: $(echo $component | tr '[:lower:]' '[:upper:]' | tr '-' '_') This upper snake case conversion seems to be happening at more than one places. Consider moving this to a helper. http://gerrit.cloudera.org:8080/#/c/24710/1/thirdparty/prebuilt-utils.sh@199 PS1, Line 199: -a Here and wherever applicable - use '&&' operator instead. -a and -o operators have been marked obsolescent. http://gerrit.cloudera.org:8080/#/c/24710/1/thirdparty/prebuilt-utils.sh@228 PS1, Line 228: local suffix=${MODE_SUFFIX} unused 'suffix' -- To view, visit http://gerrit.cloudera.org:8080/24710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52428b8f2a558feb4d8247f37351ce2b6df1e4f7 Gerrit-Change-Number: 24710 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 20 Aug 2026 07:40:09 +0000 Gerrit-HasComments: Yes
