Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24710 )

Change subject: KUDU-3788 introduce 'any' for OS, OS version, arch, toolchain
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/24710/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24710/1//COMMIT_MSG@19
PS1, Line 19: This changelist does so for
            : hadoop, hive, ranger, ranger_kms, and trace-viewer components
> question: Is that it or there are other components that might fall into thi
There are other components, yes.  The current set in PS1 is focusing on 
pre-built archives/JARs for hadoop, hive, ranger, ranger_kms -- these are huge. 
 Those hogs take a lot of space: combines, they consume more space  than the 
rest of pre-built 3rd-party archives.  Moving Java hogs into 'any' category 
allows for saving a lot of space in the S3 bucket where we store pre-built 
3rd-party archives.

I thought we could take care of the rest in a separate changelist, but it's not 
crucial to separate it.  I added them in PS2 -- it should be a complete list as 
of now.  Let me know if you think I missed anything.


http://gerrit.cloudera.org:8080/#/c/24710/1/thirdparty/prebuilt-utils.sh
File thirdparty/prebuilt-utils.sh:

http://gerrit.cloudera.org:8080/#/c/24710/1/thirdparty/prebuilt-utils.sh@192
PS1, Line 192: $(echo $component | tr '[:lower:]' '[:upper:]' | tr '-' '_')
> This upper snake case conversion seems to be happening at more than one pla
Where else did you see those?  I couldn't find anything else in 
thirdparty-related scripts.


http://gerrit.cloudera.org:8080/#/c/24710/1/thirdparty/prebuilt-utils.sh@199
PS1, Line 199: -a
> Here and wherever applicable - use '&&' operator instead.
'&&' require switching to '[[]]' operations, and I'm not going to extend the 
context of this changelist to update the rest of the code in this script 
switching to that.  I'll keep '-a' here.


http://gerrit.cloudera.org:8080/#/c/24710/1/thirdparty/prebuilt-utils.sh@228
PS1, Line 228: local suffix=${MODE_SUFFIX}
> unused 'suffix'
Done



--
To view, visit http://gerrit.cloudera.org:8080/24710
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52428b8f2a558feb4d8247f37351ce2b6df1e4f7
Gerrit-Change-Number: 24710
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Thu, 20 Aug 2026 22:44:28 +0000
Gerrit-HasComments: Yes

Reply via email to